refactor

deno.json

@@ -10,6 +10,14 @@
       "exclude": ["no-explicit-any", "require-await"]
     }
   },
+  "compilerOptions": {
+    "lib": [
+      "deno.ns",
+      "esnext",
+      "dom",
+      "dom.iterable"
+    ]
+  },
   "imports": {
     "@std/assert": "jsr:@std/assert@1"
   }

src/html.ts

@@ -3,102 +3,127 @@
  * SPDX-License-Identifier: AGPL-3.0-or-later
  */
 
-import { type Chunk, ChunkedWriter } from "./http.ts";
+import { type Chunk } from "./http.ts";
 import { ChunkedStream } from "./stream.ts";
 
 type Attrs = Record<string, string | number | boolean>;
 
-const SELF_CLOSING_TAGS = new Set([
+const VOID_TAGS = new Set([
+  "area",
+  "base",
   "br",
+  "col",
   "embed",
   "hr",
   "img",
   "input",
   "link",
   "meta",
-  "track",
+  "param",
   "source",
+  "track",
+  "wbr",
 ]);
 
+const ESCAPE_MAP: Record<string, string> = {
+  "&": "&amp;",
+  "<": "&lt;",
+  ">": "&gt;",
+  '"': "&quot;",
+  "'": "&#039;",
+};
+
 export function escape(input: string): string {
-  return input
-    .replace(/&/g, "&amp;")
-    .replace(/</g, "&lt;")
-    .replace(/>/g, "&gt;")
-    .replace(/"/g, "&quot;")
-    .replace(/'/g, "&#039;");
+  let result = "";
+  let lastIndex = 0;
+
+  for (let i = 0; i < input.length; i++) {
+    const replacement = ESCAPE_MAP[input[i]];
+    if (replacement) {
+      result += input.slice(lastIndex, i) + replacement;
+      lastIndex = i + 1;
+    }
+  }
+
+  return lastIndex ? result + input.slice(lastIndex) : input;
 }
 
-function attrsToString(
-  attrs: Attrs | undefined,
-  escape: (str: string) => string,
-): string {
+function serialize(attrs: Attrs | undefined): string {
   if (!attrs) return "";
-  const pairs = Object.entries(attrs)
-    .filter(([_, value]) => value !== undefined && value !== null)
-    .map(([key, value]) => {
-      if (value === true) return key;
-      if (value === false) return "";
-      return `${key}="${escape(String(value))}"`;
-    })
-    .filter(Boolean);
-  return pairs.length ? " " + pairs.join(" ") : "";
+  let output = "";
+
+  for (const key in attrs) {
+    const val = attrs[key];
+    if (val == null || val === false) continue;
+    output += " ";
+    output += val === true ? key : `${key}="${escape(String(val))}"`;
+  }
+
+  return output;
 }
 
-type TagFunction = {
-  (attrs: Attrs, ...children: Chunk[]): Promise<void>;
-  (...children: Chunk[]): Promise<void>;
+type TagRes = void | Promise<void>;
+
+type TagFn = {
+  (attrs: Attrs, ...children: Chunk[]): TagRes;
+  (...children: Chunk[]): TagRes;
+  (template: TemplateStringsArray, ...values: Chunk[]): TagRes;
+  (fn: () => any): TagRes;
 };
 
-type HtmlBuilder = {
-  [K: string]: TagFunction;
+type HtmlProxy = { [K in keyof HTMLElementTagNameMap]: TagFn } & {
+  [key: string]: TagFn;
 };
 
+const isTemplateLiteral = (arg: any): arg is TemplateStringsArray =>
+  Array.isArray(arg) && "raw" in arg;
+
+const isAttributes = (arg: any): arg is Record<string, any> =>
+  arg && typeof arg === "object" && !isTemplateLiteral(arg);
+
+async function render(child: any): Promise<string> {
+  if (child == null) return "";
+  if (typeof child === "string" || typeof child === "number") {
+    return String(child);
+  }
+  if (child instanceof Promise) return render(await child);
+  if (Array.isArray(child)) {
+    return (await Promise.all(child.map(render))).join("");
+  }
+  if (typeof child === "function") return render(await child());
+  return String(child);
+}
+
 export function html(
   chunks: ChunkedStream<string>,
-  write: ChunkedWriter,
-): HtmlBuilder {
-  const tags = new Map<string, (...args: any[]) => Promise<void>>();
+): HtmlProxy {
+  const cache = new Map<string, TagFn>();
+  const write = (buf: string) => !chunks.closed && chunks.write(buf);
 
-  const handler: ProxyHandler<Record<string, TagFunction>> = {
+  const handler: ProxyHandler<Record<string, TagFn>> = {
     get(_, tag: string) {
-      if (tags.has(tag)) {
-        return tags.get(tag);
+      let fn = cache.get(tag);
+      if (fn) return fn;
+
+      fn = async (...args: any[]) => {
+        const attrs = isAttributes(args[0]) ? args.shift() : undefined;
+
+        const isVoid = VOID_TAGS.has(tag.toLowerCase());
+        const attributes = serialize(attrs);
+
+        write(`<${tag}${attributes}${isVoid ? "/" : ""}>`);
+        if (isVoid) return;
+
+        for (const child of args) {
+          write(await render(child));
         }
 
-      const fn = async (...args: (Chunk | Attrs)[]) => {
-        const isTemplate = args.length === 1 && Array.isArray(args[0]) &&
-          "raw" in args[0];
-        const hasAttrs = !isTemplate && args.length &&
-          typeof args[0] === "object";
-
-        const attrs: Attrs | undefined = hasAttrs
-          ? args.shift() as Attrs
-          : undefined;
-        const children: Chunk[] = args as Chunk[];
-
-        const attributes = attrsToString(attrs, escape);
-        const isSelfClosing = SELF_CLOSING_TAGS.has(tag.toLowerCase());
-        if (!isSelfClosing && !children.length) return;
-        chunks.write(`<${tag}${attributes}${isSelfClosing ? " /" : ""}>`);
-
-        if (!isSelfClosing) {
-          if (isTemplate) {
-            await (write as any)(...children);
-          } else {
-            for (const child of children) {
-              typeof child === "function"
-                ? await (child as any)()
-                : chunks.write(String(await child));
-            }
-          }
-          chunks.write(`</${tag}>`);
-        }
+        write(`</${tag}>`);
       };
 
-      tags.set(tag, fn);
-      return fn;
+      return cache.set(tag, fn), fn;
     },
   };
-  return new Proxy({}, handler);
+
+  return new Proxy({}, handler) as HtmlProxy;
 }

src/http.ts

@@ -21,17 +21,17 @@ async function* normalize(
   value: Chunk | undefined | null,
 ): AsyncIterable<string> {
   if (value == null) return;
+
   if (typeof value === "string") {
+    3;
     yield value;
   } else if (value instanceof Promise) {
     const resolved = await value;
     if (resolved != null) yield String(resolved);
-  } else if (
-    typeof value === "object" &&
-    (Symbol.asyncIterator in value || Symbol.iterator in value)
-  ) {
+  } else if (Symbol.asyncIterator in value || Symbol.iterator in value) {
     for await (const chunk of value as AsyncIterable<string>) {
       if (chunk != null) yield String(chunk);
+      1;
     }
   } else {
     yield String(value);
@@ -43,66 +43,65 @@ export type ChunkedWriter = (
   ...values: Chunk[]
 ) => Promise<void>;
 
-export function makeChunkWriter(stream: ChunkedStream<string>): ChunkedWriter {
-  const emit = (chunk: string) => {
-    if (stream.closed) return;
-    chunk === "EOF" ? stream.close() : stream.write(chunk);
-  };
+export const makeChunkWriter =
+  (stream: ChunkedStream<string>): ChunkedWriter =>
+  async (strings, ...values) => {
+    const emit = (chunk: string) =>
+      !stream.closed &&
+      (chunk === "EOF" ? stream.close() : stream.write(chunk));
 
-  return async function (strings: TemplateStringsArray, ...values: Chunk[]) {
     for (let i = 0; i < strings.length; i++) {
-      if (strings[i]) emit(strings[i]);
+      strings[i] && emit(strings[i]);
       for await (const chunk of normalize(values[i])) {
         emit(chunk);
       }
     }
   };
-}
 
-export function chunkedHtml(): {
-  chunks: ChunkedStream<string>;
-  stream: ReadableStream<Uint8Array>;
-} {
-  const encoder = new TextEncoder();
+export function chunkedHtml() {
   const chunks = new ChunkedStream<string>();
 
   const stream = new ReadableStream<Uint8Array>({
-    async pull(controller) {
-      if (chunks.closed) return;
-      const result = await chunks.next();
-      result.done
-        ? controller.close()
-        : controller.enqueue(encoder.encode(result.value));
-    },
-    cancel() {
-      chunks.close();
+    async start(controller) {
+      const encoder = new TextEncoder();
+      for await (const chunk of chunks) {
+        controller.enqueue(encoder.encode(chunk));
+      }
+      controller.close();
     },
+    cancel: chunks.close,
   });
 
   return { chunks, stream };
 }
 
+const DOCUMENT_TYPE = "<!DOCTYPE html>";
+const HTML_BEGIN = (lang: string) =>
+  `<html lang="${lang}"><head><meta charset="utf-8"><meta name="viewport" content="width=device-width, initial-scale=1.0">`;
+const HEAD_END = "</head><body";
+const BODY_END = ">";
+const HTML_END = "</body></html>";
+
 export async function createHtmlStream(options: StreamOptions = {}) {
   const { chunks, stream } = chunkedHtml();
   const writer = makeChunkWriter(chunks);
 
-  await writer`<!DOCTYPE html>
-<html lang="${options.lang || "en"}">
-<head>
-<meta charset="utf-8">
-<meta name="viewport" content="width=device-width, initial-scale=1.0">
-${options.headContent || ""}
-</head>
-<body ${options.bodyAttributes || ""}>`;
+  chunks.write(DOCUMENT_TYPE);
+  chunks.write(HTML_BEGIN(options.lang || "en"));
+  options.headContent && chunks.write(options.headContent);
+  chunks.write(HEAD_END);
+  options.bodyAttributes && chunks.write(" " + options.bodyAttributes);
+  chunks.write(BODY_END);
 
   return {
     write: writer,
-    stream,
+    blob: stream,
     chunks,
     close() {
-      if (chunks.closed) return;
-      chunks.write("</body></html>");
+      if (!chunks.closed) {
+        chunks.write(HTML_END);
         chunks.close();
+      }
     },
     get response(): Response {
       return new Response(stream, {

src/main.ts

@@ -10,19 +10,18 @@ Deno.serve({
   port: 8080,
   async handler() {
     const stream = await createHtmlStream({ lang: "en" });
-    const { h1, p, li } = html(stream.chunks, stream.write);
+    const { h1, ol, p, li } = html(stream.chunks);
 
-    await h1`<h1>Normal Streaming Page</h1>`;
+    await h1`Normal Streaming Page`;
     await p({ class: "oh hey" }, "meowing chunk by chunk");
 
-    (async () => {
+    ol(async () => {
       const fruits = ["Apple", "Banana", "Cherry"];
-
       for (const fruit of fruits) {
         await new Promise((r) => setTimeout(r, 500));
         await li(fruit);
       }
-    })();
+    });
 
     return stream.response;
   },

src/stream.ts

@@ -5,38 +5,37 @@
 
 export class ChunkedStream<T> implements AsyncIterable<T> {
   private readonly chunks: T[] = [];
-  private readonly queue: ((result: IteratorResult<T>) => void)[] = [];
+  private readonly resolvers: ((result: IteratorResult<T>) => void)[] = [];
   private _closed = false;
 
   get closed(): boolean {
     return this._closed;
   }
 
-  write(chunk: T): void {
+  write(chunk: T) {
     if (this._closed) throw new Error("Cannot write to closed stream");
-    this.queue.shift()?.({ value: chunk, done: false }) ??
+
+    const resolver = this.resolvers.shift();
+    if (resolver) {
+      resolver({ value: chunk, done: false });
+    } else {
       this.chunks.push(chunk);
     }
+  }
 
   close(): void {
     this._closed = true;
-    this.queue.splice(0).forEach((r) => r({ value: undefined, done: true }));
+    while (this.resolvers.length) {
+      this.resolvers.shift()!({ value: undefined! as any, done: true });
+    }
   }
 
-  next(): Promise<IteratorResult<T>> {
+  async next(): Promise<IteratorResult<T>> {
     if (this.chunks.length) {
-      return Promise.resolve({
-        value: this.chunks.shift()!,
-        done: false,
-      });
+      return { value: this.chunks.shift()!, done: false };
     }
-    if (this._closed) {
-      return Promise.resolve({
-        value: undefined as any,
-        done: true,
-      });
-    }
-    return new Promise((resolve) => this.queue.push(resolve));
+    if (this._closed) return { value: undefined as any, done: true };
+    return new Promise((resolve) => this.resolvers.push(resolve));
   }
 
   [Symbol.asyncIterator](): AsyncIterableIterator<T> {
@@ -44,94 +43,65 @@ export class ChunkedStream<T> implements AsyncIterable<T> {
   }
 }
 
-export async function* mapStream<T, U>(
-  source: AsyncIterable<T>,
-  fn: (chunk: T, index: number) => U | Promise<U>,
-): AsyncIterable<U> {
-  let index = 0;
+export const mapStream = <T, U>(
+  fn: (chunk: T, i: number) => U | Promise<U>,
+) =>
+  async function* (source: AsyncIterable<T>): AsyncIterable<U> {
+    let i = 0;
+    for await (const chunk of source) yield await fn(chunk, i++);
+  };
+
+export const filterStream = <T>(
+  pred: (chunk: T, i: number) => boolean | Promise<boolean>,
+) =>
+  async function* (source: AsyncIterable<T>): AsyncIterable<T> {
+    let i = 0;
     for await (const chunk of source) {
-    yield await fn(chunk, index++);
+      if (await pred(chunk, i++)) yield chunk;
     }
-}
+  };
 
-export async function* filterStream<T>(
-  source: AsyncIterable<T>,
-  predicate: (chunk: T, index: number) => boolean | Promise<boolean>,
-): AsyncIterable<T> {
-  let index = 0;
-  for await (const chunk of source) {
-    if (await predicate(chunk, index++)) {
-      yield chunk;
-    }
-  }
-}
-
-export async function* composeStreams<T>(
-  ...sources: AsyncIterable<T>[]
-): AsyncIterable<T> {
-  for (const source of sources) {
-    yield* source;
-  }
-}
-
-export async function* takeStream<T>(
-  source: AsyncIterable<T>,
-  count: number,
-): AsyncIterable<T> {
+export const takeStream = <T>(count: number) =>
+  async function* (source: AsyncIterable<T>): AsyncIterable<T> {
     let taken = 0;
     for await (const chunk of source) {
-    if (taken++ >= count) break;
+      if (taken++ >= count) return;
       yield chunk;
     }
-}
+  };
 
-export async function* skipStream<T>(
-  source: AsyncIterable<T>,
-  count: number,
-): AsyncIterable<T> {
-  let skipped = 0;
+export const skipStream = <T>(count: number) =>
+  async function* (source: AsyncIterable<T>): AsyncIterable<T> {
+    let i = 0;
     for await (const chunk of source) {
-    if (skipped++ >= count) {
-      yield chunk;
+      if (i++ >= count) yield chunk;
     }
-  }
-}
+  };
 
-export async function* batchStream<T>(
-  source: AsyncIterable<T>,
-  size: number,
-): AsyncIterable<T[]> {
+export const batchStream = <T>(size: number) =>
+  async function* (source: AsyncIterable<T>): AsyncIterable<T[]> {
     let batch: T[] = [];
-
     for await (const chunk of source) {
       batch.push(chunk);
       if (batch.length >= size) {
-      yield batch, batch = [];
-    }
-  }
-
-  if (batch.length > 0) {
         yield batch;
+        batch = [];
       }
-}
-
-export async function* flatMapStream<T, U>(
-  source: AsyncIterable<T>,
-  fn: (chunk: T, index: number) => AsyncIterable<U> | Iterable<U>,
-): AsyncIterable<U> {
-  let index = 0;
-  for await (const chunk of source) {
-    yield* fn(chunk, index++);
     }
-}
+    batch.length && (yield batch);
+  };
 
-export async function* tapStream<T>(
-  source: AsyncIterable<T>,
-  fn: (chunk: T, index: number) => void | Promise<void>,
-): AsyncIterable<T> {
-  let index = 0;
+export const tapStream = <T>(
+  fn: (chunk: T, i: number) => void | Promise<void>,
+) =>
+  async function* (source: AsyncIterable<T>): AsyncIterable<T> {
+    let i = 0;
     for await (const chunk of source) {
       yield chunk;
-    await fn(chunk, index++);
+      await fn(chunk, i++);
     }
-}
+  };
+
+export const pipe =
+  <T>(...fns: Array<(src: AsyncIterable<T>) => AsyncIterable<any>>) =>
+  (source: AsyncIterable<T>) => fns.reduce((acc, fn) => fn(acc), source);